Re: [PATCH 1/3] USB : serial : call handle_dcd_change in ftdi driver.

[Sergei Shtylyov]

Hello.

On 09/13/2013 07:35 PM, Paul Chavent wrote:

> Signed-off-by: Paul Chavent <paul.chavent@xxxxxxxx>
> ---
>   drivers/usb/serial/ftdi_sio.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)

> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index c45f9c0..df66495 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1966,8 +1966,14 @@ static int ftdi_process_packet(struct usb_serial_port *port,
>   			port->icount.dsr++;
>   		if (diff_status & FTDI_RS0_RI)
>   			port->icount.rng++;
> -		if (diff_status & FTDI_RS0_RLSD)
> +		if (diff_status & FTDI_RS0_RLSD) {
>   			port->icount.dcd++;
> +			struct tty_struct *tty = tty_port_tty_get(&port->port);

   Don't mix declaration and code. And add an empty line between them please.

> +			if (tty)
> +				usb_serial_handle_dcd_change(port, tty,
> +						status & FTDI_RS0_RLSD);
> +			tty_kref_put(tty);
> +		}

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/