Re: [PATCH 106/228] cpufreq: integrator: don't initialize part ofpolicy that is set by core too

From: Viresh Kumar
Date: Fri Sep 13 2013 - 12:29:17 EST


On 13 September 2013 21:40, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> This patch actually changes things - the description is misleading.
> Please explain why this change - which results in different values for
> policy->min and policy->max doesn't cause any functional difference.

Yeah, see if below log looks correct (patch attached):

Subject: [PATCH 106/228] cpufreq: integrator: don't initialize part of policy
that is set by core too

Many common initializations of struct policy are moved to core now and hence
this driver doesn't need to do it. This patch removes such code.

Most recent of those changes is to call ->get() in the core after calling
->init(). And so we don't need to set policy->cur from driver anymore.

Over that it sets policy->min and max correctly. They were earlier set to
current frequency of CPU but they should be set to max and min freq of cpu.

Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
---
drivers/cpufreq/integrator-cpufreq.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Attachment: 0106-cpufreq-integrator-don-t-initialize-part-of-policy-t.patch
Description: Binary data