Re: [PATCH 2/2] gpio / ACPI: add support for GPIO operation regions

From: Andy Shevchenko
Date: Fri Sep 13 2013 - 11:55:22 EST


On Fri, Sep 13, 2013 at 6:14 PM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> GPIO operation regions is a new feature introduced in ACPI 5.0
> specification. In practise it means that now ASL code can toggle GPIOs with
> the help of the OS GPIO driver.

[]

> void acpi_gpiochip_add(struct gpio_chip *chip)
> {
> + struct acpi_gpio_chip_data *data;
> + acpi_handle handle;
> + acpi_status status;
> +
> + handle = ACPI_HANDLE(chip->dev);
> + if (!handle)
> + return;
> +
> + data = kzalloc(sizeof(*data), GFP_KERNEL);

May we use devm_kzalloc here?

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/