Re: [PATCH 2/4] scripts/config: use sed's POSIX interface

From: ClÃment Chauplannaz
Date: Fri Sep 13 2013 - 05:54:49 EST


On Sep 13, 2013, at 11:32 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> On Fri, Sep 13, 2013 at 10:38 AM, ClÃment Chauplannaz
> <chauplac@xxxxxxxxx> wrote:
>
>> Thank you for this report. I was able to reproduce this bug and fix it.
>
> Thanks! Tested and works fine.
Glad to read the patch solves your issue. Thanks for the quick feedback!
>
>> My previous commit changed the separator between sed's substitute
>> command and its parameters, from ':' to '/'. The latter conflicted
>> with the slashes found in the value of variable CMDLINE, as provided
>> in your email.
>
> Hm it could actually be useful to be able to have colons in a CMDLINE,
> I wonder if we can think about some better separator ... oh well that
> is another issue, all old scripts work now anyway.
Indeed config script may not work with all possible string values. My first concern for now was to fallback to previous interface. We may look into hardening the script later on.

Best regards,
Clement Chauplannaz--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/