Re: [PATCH 2/4] scripts/config: use sed's POSIX interface

[Clément Chauplannaz]

2013/9/12 Linus Walleij <linus.walleij@xxxxxxxxxx>:
> On Thu, Aug 15, 2013 at 11:17 PM, Yann E. MORIN <yann.morin.1998@xxxxxxx> wrote:
>
>> From: Clement Chauplannaz <chauplac@xxxxxxxxx>
>>
>> Script `config' relies on extensions of `GNU sed', and is thus not
>> working on all Unixes:
>>   - in-place edition of files (-i), which can be replaced with
>>     a temporary file;
>>   - extended-regexps (-r), which can be split into basic regexps;
>>   - single-line calls to `a' command, while some implementations
>>     require a leading newline before the parameter.
>>
>> Rewrite calls to `sed' to comply with POSIX interface, and move them
>> to helper functions.
>>
>> Signed-off-by: Clement Chauplannaz <chauplac@xxxxxxxxx>
>> Tested-by: "Yann E. MORIN" <yann.morin.1998@xxxxxxx>
>> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@xxxxxxx>
>> Signed-off-by: Yann E. MORIN <yann.morin.1998@xxxxxxx>
>
> This patch totally breaks my usage of the --set-str
> argument to "config".
>
> Reverting this patch solves the problem.
>
> Reproduce:
> make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi-
> KBUILD_OUTPUT=build-nomadik nhk8815_defconfig
> scripts/config --file build-nomadik/.config --set-str CMDLINE
> "root=/dev/ram0 console=ttyAMA1,115200n8 earlyprintk"
> sed: -e uttryck #1, tecken 44: flaggan okänd för "s"
> sed: -e uttryck #1, tecken 54: flaggan okänd för "s"
>
> Swedish messages meaning "unknown flag for "s""
>
> After reverting the patch these messages no longer appear.
>
> At failure my config file is scratched :-O
>
> Yours,
> Linus Walleij

Hello Linus,

Thank you for this report. I was able to reproduce this bug and fix it.

My previous commit changed the separator between sed's substitute
command and its parameters, from ':' to '/'. The latter conflicted
with the slashes found in the value of variable CMDLINE, as provided
in your email.

I'm sending a patch right now to revert to previous behavior.

Best regards,
Clement Chauplannaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/