Re: [RFC PATCH 1/1] module: Make wait module's refcount to zeroprocedure as async

From: Lucas De Marchi
Date: Thu Sep 12 2013 - 22:08:44 EST


On Thu, Sep 12, 2013 at 9:30 PM, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> Peter Chen <peter.chen@xxxxxxxxxxxxx> writes:
>> Currently, if module's refcount is not zero during the unload,
>> it waits there until the user decreases that refcount.
>
> Hi Peter,
>
> In practice userspace uses O_NONBLOCK. In fact, I've been
> thinking of removing the blocking case altogether, since it's not really
> what people want.
>
> That would solve your problem and make the code simpler. Thoughts?

I'm all in favor of this. It's been almost 1 year it's deprecated in
kmod and if anyone tries to use we force a 10s delay on module
removal. So far nobody complained.

Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/