Re: [PATCH v2] pstore: Adjust buffer size for compression for smallerregistered buffers

From: Aruna Balakrishnaiah
Date: Thu Sep 12 2013 - 15:22:19 EST


On Thursday 12 September 2013 11:13 PM, Luck, Tony wrote:
+ default:
+ cmpr = 60;
+ break;
+ }

Is this the right "default"? It may be a good choice for a backend with a really
tiny buffer (1 ... 999). But less good for a (theoretical) backend with a larger
buffer (10001 ... infinity and beyond). Which are you trying to catch here?

Trying to catch lower buffers and also tried till 23k ( 10k * 100/45) of text with a
sample crash logit achieved a good compression of 25%. Since the upper limit is not known
and compression behavior is not tested above 10k chose to keep a higher default of 60.

-Tony

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@xxxxxxxxxxxxxxxx
https://lists.ozlabs.org/listinfo/linuxppc-dev


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/