Re: [PATCH RT] hwlat-detector: Don't ignore threshold moduleparameter

From: Steven Rostedt
Date: Thu Sep 12 2013 - 14:23:30 EST


Don't be afraid to Cc LKML with rt kernel patches. linux-rt-users is
for users not kernel developers. People like Peter Zijlstra will never
see this patch.

On Fri, 30 Aug 2013 07:57:25 +0200
Mike Galbraith <bitbucket@xxxxxxxxx> wrote:

> If the user specified a threshold at module load time, use it.

This could use a little better change log.

Other than that,

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve

>
> Signed-off-by: Mike Galbraith <bitbucket@xxxxxxxxx>
>
> --- a/drivers/misc/hwlat_detector.c 2013-08-30 07:16:05.387959392 +0200
> +++ b/drivers/misc/hwlat_detector.c 2013-08-30 07:10:52.958670183 +0200
> @@ -413,7 +413,7 @@ static int init_stats(void)
> goto out;
>
> __reset_stats();
> - data.threshold = DEFAULT_LAT_THRESHOLD; /* threshold us */
> + data.threshold = threshold ?: DEFAULT_LAT_THRESHOLD; /* threshold us */
> data.sample_window = DEFAULT_SAMPLE_WINDOW; /* window us */
> data.sample_width = DEFAULT_SAMPLE_WIDTH; /* width us */
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/