Re: [PATCH] vt: properly ignore xterm-256 colour codes

[David Herrmann]

Hi Adam

On Mon, Sep 9, 2013 at 6:46 PM, Adam Borowski <kilobyte@xxxxxxxxxx> wrote:
> On Mon, Sep 09, 2013 at 05:53:19PM +0200, David Herrmann wrote:
>> On Fri, Jul 12, 2013 at 10:23 PM, Adam Borowski <kilobyte@xxxxxxxxxx> wrote:
>> > +                               i++;
>> > +                               if (i > vc->vc_npar)
>>
>> This should be ">=", but the for()-loop does allow your ">". So unless
>> someone fixes the for-loop to use "<" (do a ++vc->vc_npar before it,
>> if it's correct. But blindly doing "<=" is really irritating) I think
>> this is ok.
>
> The loop this switch is in does:
>         for (i = 0; i <= vc->vc_npar; i++)
> which is obviously contrary to what we're used to, but I did not want to
> rewrite nearby code to match my preferences.
>
> The change you suggest would deoptimize the code by a single unnecessary
> dereference and increment, which is negligible, but since the whole cost
> of speedier version is having <= instead of < in the loop, I'm not so
> certain this is a good idea.

This was just my comment on the weird for-loop. No need to touch it at
all, I just wondered whether anyone knows why we use <= instead of
just < here.

> [...]
>> Btw., you should put Greg Kroah-Hartman and Andrew Morton on CC. Both
>> are the most likely to pick this up.
>
> Thanks for the suggestion.  I've sent the patch two days ago to Jiri Slaby
> (listed as a maintainer besides Greg) together with a newbie question, but
> he's apparently busy.
>
> I've got more changes for the vt, but there's no hurry, I wanted to test
> the waters with a single minor one in 3.12 first.

Jiri Slaby maintains the TTY subsystem (together with Greg). This does
not include the VT layer, though. drivers/tty/vt/ and
drivers/video/console/ are unmaintained. You need to get the attention
of any maintainer who is willing to take it through their tree (hint:
most maintainers don't dare touching the VT layer. Greg and Andrew
were brave enough in the past.).

I'm willing to review your patches, but history taught me touching the
VT layer is a waste of time. Still, good luck.

Regards
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/