Re: [PATCH] perf tools: Separate out GTK codes to libperf-gtk.so

[Jiri Olsa]

On Thu, Sep 12, 2013 at 03:34:19PM +0900, Namhyung Kim wrote:
> Separate out GTK codes to a shared object called libperf-gtk.so.  This

SNIP

>  pthread_mutex_t ui__lock = PTHREAD_MUTEX_INITIALIZER;
> +void *perf_gtk_handle;
> +
> +#ifdef GTK2_SUPPORT
> +static int setup_gtk_browser(void)
> +{
> +	int (*perf_ui_init)(void);
> +
> +	if (perf_gtk_handle)
> +		return 0;
> +
> +	perf_gtk_handle = dlopen("libperf-gtk.so", RTLD_LAZY);
> +	if (perf_gtk_handle == NULL)
> +		return -1;

shouldn't we try for known installed path here?

  $ perf report --gtk
  GTK browser requested but could not find libperf-gtk.so

otherwise I need to do some ld.conf setup or run it like this:

  LD_LIBRARY_PATH=/home/jolsa/lib64/ ./perf report --gtk
  LD_LIBRARY_PATH=./ ./perf report --gtk

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/