Re: [PATCH] Drivers: hv: vmbus: fix error return code invmbus_connect()

From: Dan Carpenter
Date: Thu Sep 12 2013 - 07:11:38 EST


On Thu, Sep 12, 2013 at 12:36:46AM +0000, KY Srinivasan wrote:
> When you try a given version, vmbus_negotiate_version() returns an error code
> if the host does not support that version. Hence, in this code you will not be able to
> run on anything prior to ws2012. I have already sent in a patch to fix that - if we timeout
> only then we jump to cleanup. In any event, if we tried all versions and none was acceptable
> to the host, we would return the value from vmbus_negotiate_version().
>

First of all Wei's patch fixes an obvious bug. Read the code.

If you already fixed it then what's the URL or the subject of your
email so we can look for it in our inbox. Give us a clue here.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/