Re: [PATCH] powerpc 8xx: Fixing issue with CONFIG_PIN_TLB

From: leroy christophe
Date: Thu Sep 12 2013 - 01:57:34 EST



Le 12/09/2013 02:15, Benjamin Herrenschmidt a Ãcrit :
On Wed, 2013-09-11 at 17:36 -0500, Scott Wood wrote:
I wonder why we don't start from entry 31 so we can actually make use of
that autodecrement. What will happen when we load the first normal TLB
entry later on? I don't see any setting of SPRN_MD_CTR after this code,
so won't it overwrite entry 30 (the middle 8M) in the CONFIG_PIN_TLB
case?

Ben, would patches like this be considered bugfixes as far as merging
goes, or would they be for next given that it's something that's never
really worked right and hasn't been touched in years?
Since they don't affect anything outside of 8xx, I'm happy to take them
until around -rc2 or 3. But it's your call really.


Scott, you're right, I didn't see that other consequence.
I'll come with a more complete patch this afternoon.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/