Re: [PATCH] drm/omap: fix error return code in omap_dmm_probe()

From: Rob Clark
Date: Wed Sep 11 2013 - 07:27:32 EST


On Wed, Sep 11, 2013 at 7:16 AM, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> Fix to return -ENOMEM in the refill memory alloc error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>

Thanks

Reviewed-by: Rob Clark <robdclark@xxxxxxxxx>

> ---
> drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 9b794c9..ab546c9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -675,6 +675,7 @@ static int omap_dmm_probe(struct platform_device *dev)
> &omap_dmm->refill_pa, GFP_KERNEL);
> if (!omap_dmm->refill_va) {
> dev_err(&dev->dev, "could not allocate refill memory\n");
> + ret = -ENOMEM;
> goto fail;
> }
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/