Re: Resend: [PATCH 2/2] s390: provide hardware randomness fromzcrypt card to /dev/random

From: Joe Perches
Date: Tue Sep 10 2013 - 20:39:42 EST


On Wed, 2013-09-04 at 10:48 +0200, Torsten Duwe wrote:
[]
> +++ b/drivers/s390/crypto/zcrypt_api.c

> @@ -1141,6 +1144,36 @@ static struct hwrng zcrypt_rng_dev = {
][
> +static int zcrypt_hwrng_fillfn(void *unused)
> +{
> + long rc;
> +
> + while (!kthread_should_stop()) {
> + rc = zcrypt_rng((char *)zcrypt_rng_buffer);
> + if (rc == -ENODEV || rc == -EINVAL || rc == -ENOMEM) {
> + pr_err("zcrypt_rng unavailable: %ld", rc);

please add terminating newlines

pr_err("zcrypt_rng unavailable: %ld\n", rc);

etc...



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/