Re: [PATCH] panic: call panic handlers before kmsg_dump

From: Kees Cook
Date: Tue Sep 10 2013 - 18:45:05 EST


On Tue, Sep 10, 2013 at 3:41 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> On Thu, Jul 18, 2013 at 4:17 PM, Tony Luck <tony.luck@xxxxxxxxx> wrote:
>> On Thu, Jul 18, 2013 at 4:03 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>>> Since the panic handlers may produce additional information (via printk)
>>> for the kernel log, it should be reported as part of the panic output
>>> saved by kmsg_dump(). Without this re-ordering, nothing that adds
>>> information to a panic will show up in pstore's view when kmsg_dump
>>> runs, and is therefore not visible to crash reporting tools that examine
>>> pstore output.
>>
>> Good point.
>>
>> Acked-by: Tony Luck <tony.luck@xxxxxxxxx>
>
> Can someone pick this patch up? If akpm doesn't want it, it could live
> in the pstore tree maybe?

Ah, sorry, it seems like it is already in -mm. Never mind!

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/