Re: [PATCH] [RFC] seqcount: Add lockdep functionality toseqcount/seqlock structures

From: Peter Zijlstra
Date: Tue Sep 10 2013 - 05:19:57 EST


On Tue, Sep 10, 2013 at 10:11:56AM +0200, Peter Zijlstra wrote:
> On Mon, Sep 09, 2013 at 09:42:46PM -0700, John Stultz wrote:
> > +++ b/include/linux/lockdep.h
> > @@ -510,6 +510,21 @@ static inline void print_irqtrace_events(struct task_struct *curr)
> >
> > #ifdef CONFIG_DEBUG_LOCK_ALLOC
> > # ifdef CONFIG_PROVE_LOCKING
> > +# define seqcount_acquire(l, s, t, i) lock_acquire(l, s, t, 0, 2, NULL, i)
> > +# define seqcount_acquire_read(l, s, t, i) lock_acquire(l, s, t, 2, 2, NULL, i)
> > +# else
> > +# define seqcount_acquire(l, s, t, i) lock_acquire(l, s, t, 0, 1, NULL, i)
> > +# define seqcount_acquire_read(l, s, t, i) lock_acquire(l, s, t, 2, 1, NULL, i)
> > +# endif
> > +# define seqcount_release(l, n, i) lock_release(l, n, i)
> > +#else
> > +# define seqcount_acquire(l, s, t, i) do { } while (0)
> > +# define seqcount_acquire_read(l, s, t, i) do { } while (0)
> > +# define seqcount_release(l, n, i) do { } while (0)
> > +#endif
>
> Please look at a recent lockdep.h, this pattern changed a little.

And when you're there, can you please remove the superfluous whitespace
before rwsem_release and lock_map_release ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/