Re: [112/121] m32r: consistently use "suffix-$(...)"

From: Hirokazu Takata
Date: Tue Sep 10 2013 - 00:04:20 EST


Acked-by: Hirokazu Takata <takata@xxxxxxxxxxxxxx>

Sorry, it is my old mistake that still remained in the m32r kernel.
Please apply this patch.

Thanks,

-- Takata

From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
Subject: [112/121] m32r: consistently use "suffix-$(...)"
Date: Sun, 08 Sep 2013 03:52:01 +0100
> 3.2.51-rc1 review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>
> commit df12aef6a19bb2d69859a94936bda0e6ccaf3327 upstream.
>
> Commit a556bec9955c ("m32r: fix arch/m32r/boot/compressed/Makefile")
> changed "$(suffix_y)" to "$(suffix-y)", but didn't update any location
> where "suffix_y" is set, causing:
>
> make[5]: *** No rule to make target `arch/m32r/boot/compressed/vmlinux.bin.', needed by `arch/m32r/boot/compressed/piggy.o'. Stop.
> make[4]: *** [arch/m32r/boot/compressed/vmlinux] Error 2
> make[3]: *** [zImage] Error 2
>
> Correct the other locations to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: Hirokazu Takata <takata@xxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> ---
> arch/m32r/boot/compressed/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/m32r/boot/compressed/Makefile b/arch/m32r/boot/compressed/Makefile
> index 177716b..01729c2 100644
> --- a/arch/m32r/boot/compressed/Makefile
> +++ b/arch/m32r/boot/compressed/Makefile
> @@ -43,9 +43,9 @@ endif
>
> OBJCOPYFLAGS += -R .empty_zero_page
>
> -suffix_$(CONFIG_KERNEL_GZIP) = gz
> -suffix_$(CONFIG_KERNEL_BZIP2) = bz2
> -suffix_$(CONFIG_KERNEL_LZMA) = lzma
> +suffix-$(CONFIG_KERNEL_GZIP) = gz
> +suffix-$(CONFIG_KERNEL_BZIP2) = bz2
> +suffix-$(CONFIG_KERNEL_LZMA) = lzma
>
> $(obj)/piggy.o: $(obj)/vmlinux.scr $(obj)/vmlinux.bin.$(suffix-y) FORCE
> $(call if_changed,ld)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/