Re: [PATCH v3 2/2] Documentation: dt: hwmon: add OF document forLM90

From: Stephen Warren
Date: Mon Sep 09 2013 - 18:14:51 EST


On 09/09/2013 04:52 AM, Guenter Roeck wrote:
> On 09/09/2013 03:29 AM, Wei Ni wrote:
>> Add OF document for LM90 in Documentation/devicetree/.

>> diff --git a/Documentation/devicetree/bindings/hwmon/lm90.txt

>> +* LM90 series thermometer.
>> +
>> +Required node properties:
>> +- compatible: manufacture and chip name, one of
>
> manufacturer
>
>> + "<manufacture>,adm1032"
...
>> + "<manufacture>,sa56004"
>
> Shouldn't the manufacturers be listed explicitly ?

Yes, and they must all be present in
Documentation/devicetree/bindings/vendor-prefixes.txt.

>> +Example LM90 node:
>> +
>> +temp-sensor {
>> + compatible = "onnn,nct1008";
>> + reg = <0x4c>;
>> + vcc-supply = <&palmas_ldo6_reg>;
>> + interrupt-parent = <&gpio>;
>
> List above as optional property.

I believe it's common not to document this, since it's implicitly
supported as part of any node that is an interrupt source.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/