Re: [PATCH] rcu: Is it safe to enter an RCU read-side criticalsection?

From: Ingo Molnar
Date: Mon Sep 09 2013 - 12:11:40 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Mon, 9 Sep 2013 18:00:24 +0200
> Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> > So my NAK stands: you are still in denial, you should stop the silly
> > arguing and you should stop wasting maintainer time. You need to
> > address PeterZ's review feedback and fix the bugs in your patches,
> > ASAP.
>
> To Christoph's credit. He did post patches with debug checks. We just
> need to get around to review them.

I saw those, he posted 'needs testing' patches. He still behaved
passive-aggressively, pretending that it was some difficult task to
perform, as if we were pulling his teeth.

And in this thread he still arguing nonsense in the middle in the merge
window, claiming that CONFIG_PREEMPT=y is 'academic' - when just a cursory
look at lkml or just about anywhere else would tell him that amongst bug
reporters on lkml it's as popular as the other preempt options.

Adding and keeping preempt checks is not rocket science.

The thing is, we should not be forced to shout at him at all: Christoph's
should be _proactive_ in addressing the shortcomings that were readily
pointed out literally years ago during review in a friendly fashion,
instead of wasting a lot of people's time trying to argue around it...

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/