Re: suspicious RCU usage with unlazy_walk()

From: Linus Torvalds
Date: Mon Sep 09 2013 - 10:31:49 EST


On Sun, Sep 8, 2013 at 1:46 AM, Jerry Snitselaar
<jerry.snitselaar@xxxxxxxxxx> wrote:
> Running 3.11.0-07547-g44598f9 I hit the following last night. I have
> not had it reproduce since then. Should there be some lock cleanup in
> the error path prior to the dput() call like unlock_rcu_walk()?

Heh. I should have read more email yesterday, but I was too busy
looking at the dentry code, so I didn't get to some of my mailbox
until now.

Happily, the reason I was too busy was that I had noticed that my
d_rcu_to_refcount() changes were bad, and spent that time cleaning it
up and fixing this bug.

So this should be fixed in the current tree (current top of tree,
commit e5c832d55588 in particular).

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/