Re: [PATCH] kernel-doc: Update script to find more "Return:"sections

From: Joe Perches
Date: Mon Sep 09 2013 - 00:11:42 EST


On Sun, 2013-09-08 at 20:05 -0500, Rob Landley wrote:
> On 09/03/2013 07:34:28 PM, Joe Perches wrote:
> > Many kernel-doc return description sections headers
> > use variants of the "Return:" section prefix.
> >
> > (some or maybe even most of these aren't in
> > kernel-doc sections, but many are)
> >
> > $ git grep -E -i "^\s*\*\s*return[s]?:"| \
> > cut -f2- -d":" | awk '{print $1 $2}' | \
> > sort | uniq -c
> > 121 *return:
> > 838 *Return:
> > 778 *RETURN:
> > 191 *returns:
> > 1965 *Returns:
> > 603 *RETURNS:
> >
> > Rather than change all of the variants to the
> > canonical "Return:", adapt the script to accept
> > case insensitive "Return:" and "Returns:"
> >
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> > ---
> >
> > I don't know that this actually works.
> > It does seem right though.
> >
> > Randy? Rob? Can you test this please?
>
> I stopped reading this file at the line "#!/usr/bin/perl -w", but I'm
> not sure if this is the right approach. Something that finds these and
> lets us patch them to the cannonical version might be more appropriate.

~3500 different lines to patch is a lot.

> Or are you going to add similar fuzzy matching for all the other
> keywords?

What other keywords are there that are not freeform?

The only other style I know of is @arg:

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/