Re: [PATCH] staging: Disable lustre file system for MIPS, SH, andXTENSA

[Guenter Roeck]

On 09/08/2013 07:31 PM, Greg Kroah-Hartman wrote:
> On Sun, Sep 08, 2013 at 07:24:19PM -0700, Guenter Roeck wrote:
> > On 09/08/2013 06:59 PM, Greg Kroah-Hartman wrote:
> > > On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote:
> > > > mips allmodconfig fails with
> > > >
> > > > ERROR: "copy_from_user_page" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
> > > > undefined!
> > > >
> > > > which is due to LUSTRE using copy_from_user_page which is not exported by any
> > > > architecture.
> > >
> > > Any, or just these arches?
> > Other architectures implement it as define as far as I can see.
>
> Then why would it be a problem?
It isn't a problem for those other architectures. Mostly it is mapped to functions like memcpy().

Guenter

> > > > Unfortunately, LUSTRE can only be built as module, so there is no
> > > > easy fix.
> > >
> > > Can't we just export the functions for those arches?  Surely lutre
> > > isn't the first/only driver that needs this?
> > That would be another option.
> >
> > Actually, turns out Geert submitted a patch to do this for mips already, and Ralf applied it:
> >
> > https://lkml.org/lkml/2013/9/5/111
> >
> > So please forget this patch. If sh/xtensa actually need it, we can do the same there.
>
> Sounds good to me, consider it forgotten :)
>
> greg k-h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/