Re: [PATCH v3 1/1] dcache: Translating dentry into pathname withouttaking rename_lock

From: Al Viro
Date: Sun Sep 08 2013 - 00:58:24 EST


On Sun, Sep 08, 2013 at 12:15:46PM +0800, Ian Kent wrote:
> > and *name is never modified in it. Why not simply pass it by value?
> > Moreover, I'm not sure I understand what do we need sbi->fs_lock in
> > there. Other than that, it's very close to dentry_path() (well, that
> > and different calling conventions). Ian?
>
> Yes, it is close to dentry_path() but the path functions used to return
> the full path to the root, although I don't see where dentry_path() get
> the root, mmm ...

dentry_path(), unlike d_path(), is relative to the root of filesystem
containing dentry in question. There are 3 of those suckers:
d_path(): vfsmount/dentry => path to current process' root
d_absolute_path(): ditto, but ignores chroot jails (goes to
the absolute root of namespace)
dentry_path(): dentry => path from root of fs containing that
dentry.

IOW, if you have something mounted on /jail/mnt/foo and are chrooted into
/jail, passing vfsmount/dentry of /jail/mnt/foo/bar/baz to d_path() will
yield "/mnt/foo/bar/baz", to d_absolute_path() - "/jail/mnt/foo/bar/baz" and
passing the same dentry to dentry_path() - "/bar/baz".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/