Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS statemanagement.

From: Sudeep Dutt
Date: Fri Sep 06 2013 - 14:29:54 EST


On Thu, 2013-09-05 at 21:58 -0700, Greg Kroah-Hartman wrote:
> Again, very minor fixups for later (I can even do them...)
>
> > +static DEVICE_ATTR(state, S_IRUGO|S_IWUSR, mic_show_state, mic_store_state);
>
> DEVICE_ATTR_RW() please.
>
> Same for the other attributes you create in this patch.
>

Sure, we will incorporate these changes along with your other feedback
in patch 1 and post the next revision of this patch series.

Thanks for the review!
Sudeep Dutt



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/