Re: [PATCH] spi/drivers: Restrict COMPILE_TEST by HAS_DMA whereneeded

From: Mark Brown
Date: Fri Sep 06 2013 - 11:41:27 EST


On Fri, Sep 06, 2013 at 04:55:40PM +0200, Geert Uytterhoeven wrote:
> commit dd1053a93fdc11d491f5460f7da5ce70e6c93c9e ("spi/drivers: Enable build
> of drivers with COMPILE_TEST") allows compile-testing drivers on platforms
> they're not meant for.

> However, adding "|| COMPILE_TEST" bypasses all other implicit dependencies
> assumed by the platform dependencies before, like HAS_DMA.

> If NO_DMA=y:

Why is the fix for this not to have the DMA APIs provide shims (or
whatever platforms are affected implement the DMA API)?

Attachment: signature.asc
Description: Digital signature