Re: [PATCH] can: pcan_usb_core: fix memory leak on failure paths inpeak_usb_start()

From: Stephane Grosjean
Date: Fri Sep 06 2013 - 02:58:52 EST



Le 06/09/2013 08:56, Marc Kleine-Budde a Ãcrit :
On 09/06/2013 08:52 AM, Stephane Grosjean wrote:
Tx and rx urbs are not deallocated if something goes wrong in peak_usb_start().
The patch fixes error handling to deallocate all the resources.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
Acked-by: Stephane Grosjean <s.grosjean@xxxxxxxxxxxxxxx>
Tnx,
Marc

BTW: A simply reply to the original patch with your Acked-by is sufficient.


Ok, thx Marc. I keep it in mind for the next time (if any ;-))

StÃphane
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391 Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@xxxxxxxxxxxxxxx
----
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/