Re: drivers/staging/bcm/InterfaceMisc.c-checkpatchcleanup-(foo*)->(foo *)
From: Greg Kroah-Hartman
Date: Thu Sep 05 2013 - 12:01:22 EST
On Thu, Sep 05, 2013 at 09:21:54PM +0530, Avi wrote:
> >From 91e1d42ce8b52cc28689ea4e56c71b790217cf91 Mon Sep 17 00:00:00 2001
> From: AVI <avi@avi-VPCCW15FG.(none)>
Why have you attached your patch? And this "From:" line is obviously
wrong :(
> Date: Thu, 5 Sep 2013 21:03:45 +0530
> Subject: [PATCH] drivers/staging/bcm/InterfaceMisc.c:107: ERROR: "(foo*)"
> should be "(foo *)"
> Signed-off-by: Avinash Kumar <avi.kp.137@xxxxxxxxx>
You need to put some type of description in the changelog section.
And a new line before the signed-off-by: line.
Can you just use git send-email to send the patch, and not attach it, so
that I don't have to hand-edit the patch in order to apply it properly?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/