Re: [GIT PULL] perf changes for v3.12

From: Ingo Molnar
Date: Thu Sep 05 2013 - 08:51:13 EST



* Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> > Btw., a side note, append_chain() is a rather confusing function in
> > itself, with logic-inversion gems like:
> >
> > if (!found)
> > found = true;
>
> The check is pointless yeah, I'll remove that.

Are you sure it can be removed as-is? It inverts the 'found' condition,
which then can be used later on AFAICS. (I haven't looked very deeply
though.)

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/