Re: [PATCH v2 0/4] acpi: Fix and cleanup in acpi.

From: Tang Chen
Date: Wed Sep 04 2013 - 21:58:25 EST


On 09/05/2013 07:50 AM, Rafael J. Wysocki wrote:
On Tuesday, September 03, 2013 04:45:37 PM Tang Chen wrote:
This patch-set fix the following problems:

1. Kill useless function save_add_info() which will block us from using
numa when MEMORY_HOTPLUG is not configured.
2. acpi_table_parse() didn't check if @id is NULL.
3. Fix incorrect comment in acpi_table_parse(), and return -ENOENT if a
table is not found.

And also did some cleanup.

change log v1 -> v2:
1. Use pr_fmt() to simply the SRAT message.
Suggested by Joe Perches<joe@xxxxxxxxxxx>
2. Improve the log in patch 4, and change the return value of the stub of
acpi_table_parse() in linux/acpi.h
Suggested by Toshi Kani<toshi.kani@xxxxxx>
3. Merge the two pr_{info|err} patches into one.
4. Remove on of the patch that has been merged by Rafael.

Tang Chen (4):
acpi, numa, mem_hotplug: Kill save_add_info().
acpi cleanup: Use pr_{info|err}() instead of printk() in
arch/x86/mm/srat.c
acpi: Check if @id is NULL in acpi_table_parse()
acpi: Return -ENOENT in acpi_table_parse() and fix wrong comment.

Thanks for the patches!

Peter, any objections against [1-2/4]? If not, I'll queue them up for 3.13.

Hi Rafael,

Thanks for the checking. As Ishimatu has sent some comments for patch 2, I'd like
to send a v3 patch-set soon. Please queue the coming v3 patches.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/