Re: [PATCH 1/2] SDT markers listing by perf

From: Hemant
Date: Wed Sep 04 2013 - 13:52:30 EST


On 09/04/2013 12:51 PM, Masami Hiramatsu wrote:
(2013/09/03 16:36), Hemant Kumar wrote:
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
index 5f720dc..f2d17b7 100644
--- a/tools/perf/util/symbol.h
+++ b/tools/perf/util/symbol.h
@@ -197,6 +197,17 @@ struct symsrc {
#endif
};
+/* Note structure */
+struct sdt_note {
+ const char *name;
+ const char *provider;
+ union {
+ Elf64_Addr a64[3];
+ Elf32_Addr a32[3];
+ } addr;
+ struct sdt_note *next;
+};
Hmm, could you use struct list_head for listing up the data?

Thank you,


Yes, it will be better to use struct list_head for fetching the markers in a list. Will do that in the next iteration.

Thanks
Hemant

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/