Re: [PATCH 1/2] Move and rename HP watchdog timer driver

From: Guenter Roeck
Date: Wed Sep 04 2013 - 01:57:08 EST


On 09/03/2013 10:51 PM, Matthew Garrett wrote:
On Tue, 2013-09-03 at 22:43 -0700, Guenter Roeck wrote:

If that is the case, wouldn't it make more sense to have separate drivers,
one per functionality, plus an mfd driver to bind them all together ?

It'd be an option, but I don't think there's a huge benefit - the
functionality's reasonably related and there's no real internal bus
architecture on the device.

On the other side it is much cleaner. drivers/mfd/lpc_sch.c and drivers/mfd/lpc_ich.c
are good examples.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/