Re: [PATCH 06/11] memblock: Improve memblock to support allocationfrom lower address.

[Tang Chen]

On 09/04/2013 08:24 AM, Toshi Kani wrote:
......
> > +phys_addr_t __init_memblock
> > +__memblock_find_range(phys_addr_t start, phys_addr_t end,
> > +		      phys_addr_t size, phys_addr_t align, int nid)
>
> This func should be static as it must be an internal func.
......
> > +phys_addr_t __init_memblock
> > +__memblock_find_range_rev(phys_addr_t start, phys_addr_t end,
> > +			  phys_addr_t size, phys_addr_t align, int nid)
>
> Ditto.
......
> > +	if (memblock.current_order == MEMBLOCK_ORDER_DEFAULT)
>
> This needs to use MEMBLOCK_ORDER_HIGH_TO_LOW since the code should be
> independent from the value of MEMBLOCK_ORDER_DEFAULT.

OK, followed.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/