Re: [PATCH v7 1/4] spinlock: A new lockref structure for locklessupdate of refcount

[Linus Torvalds]

On Tue, Sep 3, 2013 at 2:13 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> This is the one that actually compiles.  Whether it *works* is still a
> total mystery.

It generates ok code, and it booted, so it seems to work at least for my config.

However, it seems to make no performance-difference what-so-ever, and
lg_local_lock is still using about 7% cpu per the profiles.

The code generation is slightly better, but the profile looks the same:

       â    ffffffff81078e70 <lg_local_lock>:
  0.62 â      push   %rbp
  0.28 â      mov    %rsp,%rbp
  0.22 â      add    %gs:0xcd48,%rdi
  0.27 â      mov    $0x100,%eax
 97.22 â      lock   xadd   %ax,(%rdi)
  0.01 â      movzbl %ah,%edx
       â      cmp    %al,%dl
  0.56 â    â je     29
       â      xchg   %ax,%ax
  0.00 â20:   pause
  0.00 â      movzbl (%rdi),%eax
       â      cmp    %dl,%al
       â    â jne    20
       â29:   pop    %rbp
  0.81 â    â retq

but it still obviously doesn't do the "lock xadd %ax,%gs:(%rdi)"
(without the preceding 'add') that would be the optimal code.

I'll try to hack that up too, but it's looking like it really is just
the "lock xadd", not the memory dependency chain..

            Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/