Re: usb: host: Faraday fotg210-hcd driver

From: Dave Jones
Date: Tue Sep 03 2013 - 17:16:03 EST


On Tue, Sep 03, 2013 at 06:59:12PM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=1dd3d123239179fad5de5dc00a6e0014a1918fde
> Commit: 1dd3d123239179fad5de5dc00a6e0014a1918fde
> Parent: 10e232c597ac757e7f8600649f7e872e86de190f
> Author: Yuan-Hsin Chen <yhchen@xxxxxxxxxxxxxxxx>
> AuthorDate: Wed Jun 19 19:53:04 2013 +0000
> Committer: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> CommitDate: Wed Jul 24 16:04:53 2013 -0700
>
> usb: host: Faraday fotg210-hcd driver
>
> FOTG210 is an OTG controller which can be configured as an
> USB2.0 host. FOTG210 host is an ehci-like controller with
> some differences. First, register layout of FOTG210 is
> incompatible with EHCI. Furthermore, FOTG210 is lack of
> siTDs which means iTDs are used for both HS and FS ISO
> transfer.
>
> Signed-off-by: Yuan-Hsin Chen <yhchen@xxxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

> +config USB_FOTG210_HCD
> + tristate "FOTG210 HCD support"
> + depends on USB
> + default N
> + ---help---
> + Faraday FOTG210 is an OTG controller which can be configured as
> + an USB2.0 host. It is designed to meet USB2.0 EHCI specification
> + with minor modification.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called fotg210-hcd.
> +

Shouldn't this depend on USB_OTG ?
Seems odd to have OTG related options presented to me when I have that unset.

Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/