Re: [gcv v3 08/35] tracing: Replace __get_cpu_var uses

From: Christoph Lameter
Date: Tue Sep 03 2013 - 10:34:12 EST


On Thu, 29 Aug 2013, Steven Rostedt wrote:

> On Wed, 28 Aug 2013 19:48:16 +0000
>
> > Index: linux/kernel/trace/trace.c
> > ===================================================================
> > --- linux.orig/kernel/trace/trace.c 2013-08-26 14:25:53.000000000 -0500
> > +++ linux/kernel/trace/trace.c 2013-08-26 14:26:29.464993617 -0500
> > @@ -1676,7 +1676,7 @@ static void __ftrace_trace_stack(struct
> > */
> > barrier();
> > if (use_stack == 1) {
> > - trace.entries = &__get_cpu_var(ftrace_stack).calls[0];
> > + trace.entries = this_cpu_ptr(ftrace_stack.calls);
> > trace.max_entries = FTRACE_STACK_MAX_ENTRIES;
> >
> > if (regs)
>
>
> This patch fails to build:
>
> kernel/trace/trace.c: In function â__ftrace_trace_stackâ:
> kernel/trace/trace.c:1679:20: error: cast specifies array type

That is because you did not apply the first patch of this series that
fixes a bug in the macros.