Re: [PATCH v3 0/3] cleanup of gpio_pcf857x.c

From: Kuninori Morimoto
Date: Mon Sep 02 2013 - 02:55:15 EST



Hi

Sorry for my many response.

> This patch series
> - removes the irq_demux_work
> - Uses devm_request_threaded_irq
> - Call the user handler iff gpio_to_irq is done.
>
> v1 --> v2
> Split v1 to 3 patches
> v2 --> v3
> Remove the unnecessary dts patches.
>
>
> George Cherian (3):
> gpio: pcf857x: change to devm_request_threaded_irq
> gpio: pcf857x: remove the irq_demux_work
> gpio: pcf857x: call the gpio user handler iff gpio_to_irq is done
>
> drivers/gpio/gpio-pcf857x.c | 51 +++++++++++++++++++++++----------------------
> 1 file changed, 26 insertions(+), 25 deletions(-)

Basically, I have no objection about these patches,
but I have 2 opinions
- I guess we can merge #1 and #2 patches ?
("as is" is very OK for me though)
- we don't need gpio->irq any more ?
(additional patch is very OK for me)

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/