Re: [PATCH 3/3] extcon: Simplify extcon_dev_register() prototype byremoving unnecessary parameter

[Greg KH]

On Mon, Sep 02, 2013 at 09:20:08AM +0900, Chanwoo Choi wrote:
> This patch remove extcon_dev_register()'s second parameter which means
> the pointer of parent device to simplify prototype of this function.

No, please don't.  You want the parent to be passed in, as the core
needs it when it is registered with the system, otherwise it will not
show up in sysfs properly (i.e. you can't set it afterwards.)

> So, if extcon device has the parent device, it should set the pointer of
> parent device to edev.dev.parent in extcon device driver instead of in
> extcon_dev_register().

No it will break things if you do that :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/