Re: [RFC][PATCH 15/18 v2] ftrace/rcu: Mark functions that are RCUunsafe

From: Paul E. McKenney
Date: Sat Aug 31 2013 - 16:54:36 EST


On Sat, Aug 31, 2013 at 04:43:24PM -0400, Steven Rostedt wrote:
> On Sat, 2013-08-31 at 13:00 -0700, Paul E. McKenney wrote:
> > On Sat, Aug 31, 2013 at 01:11:32AM -0400, Steven Rostedt wrote:
> > > From: "Steven Rostedt (Red Hat)" <rostedt@xxxxxxxxxxx>
> > >
> > > Some callbacks of the function tracer use rcu_read_lock(). This means that
> > > there's places that can not be traced because RCU is not tracking the CPU
> > > for various reasons (like NO_HZ_FULL and coming back from userspace).
> > >
> > > Thes functions need to be marked so that callbacks that use RCU do not
> > > trace them.
> > >
> > > Cc: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> >
> > Reviewed-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> >
> > Please let me know if you would like me to take this one. If I don't
> > hear otherwise, I will assume that you are pushing it.
> >
>
> These I rather take, as they are all dependent on the previous changes.

Good point, applies to the other one we discussed as well.

Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/