Re: [PATCH 01/16] Move common EFI stub code from x86 arch code to common location

[Grant Likely]

On Tue, 13 Aug 2013 09:56:20 -0400, Mark Salter <msalter@xxxxxxxxxx> wrote:
> On Fri, 2013-08-09 at 16:26 -0700, Roy Franz wrote:
> > No code changes made, just moving functions from x86 arch directory
> > to common location.
> > Code is shared using #include, similar to how decompression code
> > is shared among architectures.
> > 
> > Signed-off-by: Roy Franz <roy.franz@xxxxxxxxxx>
> > ---
> 
> Tested on arm64.
> 
> Acked-by: Mark Salter <msalter@xxxxxxxxxx>

Looks okay to me. I'm not a big fan of #including .c files, but I'm okay
with it as-is for the time being. It can be revisited later to
investigate a clean way to compile these functions as a separate .o file.

Reviewed-by: Grant Likely <grant.likely@xxxxxxxxxx>

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/