Re: [PATCH 05/10] asus-wmi: Restrict debugfs interface when moduleloading is restricted

From: H. Peter Anvin
Date: Thu Aug 29 2013 - 14:47:10 EST


On 08/29/2013 11:35 AM, Matthew Garrett wrote:
> On Thu, 2013-08-29 at 11:22 -0700, H. Peter Anvin wrote:
>> On 08/19/2013 09:10 AM, Matthew Garrett wrote:
>>> + if (!capable(CAP_COMPROMISE_KERNEL))
>>> + return -EPERM;
>>> +
>>
>> Stale bits?
>
> Yeah. Did I manage to send out the old copy of that again? I'm sorry,
> spending a few months concentrating on cloud stuff seems to have
> entirely destroyed my ability to deal with git :(
>

No, you mixed and matched in a single patch...

I still believe that CAP_RAWIO should be forbidden in this case.

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/