Re: [PATCH v3] gpio: add GPIO support for F71882FG and F71889F

From: Guenter Roeck
Date: Thu Aug 29 2013 - 13:31:42 EST


On Thu, Aug 29, 2013 at 05:25:51PM +0100, Matthew Garrett wrote:
> On Thu, Aug 29, 2013 at 09:08:30AM -0700, Guenter Roeck wrote:
> > On Thu, Aug 29, 2013 at 04:37:38PM +0100, Matthew Garrett wrote:
> > > On Thu, Aug 29, 2013 at 06:41:41AM -0700, Guenter Roeck wrote:
> > > The majority of board vendors clearly don't expect the OS to drive the
> > > hwmon chips - they're there for the benefit of ACPI and SMM code. That
> > > doesn't mean that there's no benefit in having drivers for them, just
> > > that the board vendors don't care about that use case and so won't do
> > > anything to make it easier.
> > >
> > Actually, not entirely true. Some vendors even provide software running on
> > Windows to access those chips (including access to fans controlled through
> > GPIO pins) and to provide information to the user. It might be more accurate
> > to say that some board vendors don't care about Linux (or about providing
> > access through ACPI, for that matter).
>
> Eh. If they're really providing code that just assumes that hardware is
> present and bangs on it, what choice do we have? You've checked that the
> machines in question don't have a magic ACPI device that provides
> resource information?
>
Not to my knowledge. One vendor doing this extensively is ASRock. They have
a Windows based tuning aplication which lets users even set chip voltages
through SuperIO GPIO pins. Not that I would recommend supporting anything
like that in Linux ;).

I also have a couple of Intel motherboards which don't support ACPI methods
to access hardware monitoring information or the watchdog on the SuperIO chip.
Guess they don't want me to use that information ;).

There is lots of hardware monitoring tools available for Windows. Practically
none of them uses ACPI to collect the information from the hardware. Instead,
they use the same method we use in the Linux kernel to detect the SuperIO chip.
An open source tool is http://openhardwaremonitor.org/.

> > Question here is what the Linux kernel community's policy is going to be
> > to handle such cases. Pragmatic or dogmatic ?
>
> I don't see any benefit in changing the status quo. Sometimes hardware
> is just shit. The majority of x86 vendors certainly don't care about
> anything we do, so it's not like we're in a position to force them to
> change.
>
Me not either. It just sounded to me that this was the suggestion, so I was
asking for clarification. It doesn't make sense for people like me to submit
a driver into the kernel only to have it rejected for non-technical reasons.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/