Re: [PATCH] ARC: Fix __udelay parentheses

From: Joe Perches
Date: Thu Aug 29 2013 - 02:37:14 EST


On Thu, 2013-08-29 at 06:24 +0000, Vineet Gupta wrote:
> On 08/29/2013 11:31 AM, Joe Perches wrote:
> > I think the whole thing is odd and it should simply be
> >
> > loops = loops_per_jiffy * usecs_to_jiffies(usecs)
[]
> On the topic of multiply vs. divide (which probably is not relevant to topic at
> hand though), since ARCompact doesn't have native divide, we end up emulating it
> using libgcc routines. That makes it slightly non-deterministic (not a big deal)
> and also adds to boot time (which those delays sprinkled all over the place in
> crazy device probes and such). Seriously we got hammered by a customer for that once.

That argues more for reducing the uses of hard delays
than making the hard delay count calculation simpler.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/