Re: [PATCH v5 2/2] iio: add Bosch BMA180 acceleration sensor driver

[Jonathan Cameron]

On 08/28/13 14:17, Mark Rutland wrote:
> On Wed, Aug 28, 2013 at 12:01:18PM +0100, Oleksandr Kravchenko wrote:
>> This patch adds IIO driver for Bosch BMA180 triaxial
>> acceleration sensor.
>> http://dlnmh9ip6v2uc.cloudfront.net/datasheets/
>>                 Sensors/Accelerometers/BST-BMA180-DS000-07_2.pdf
>>
>> Stephen Warren:
>> The binding looks simple enough to me, so the binding
> 
> You can lose the above two lines, just the Acked-by is good enough. :)
> 
>> Acked-by: Stephen Warren <swarren@xxxxxxxxxx>
>> Signed-off-by: Oleksandr Kravchenko <o.v.kravchenko@xxxxxxxxxxxxxxx>
Bonus text dropped and signoff/ack reordered as the Author goes at the top
then the chain is as people ack/sign off after that.

Applied to the togreg branch of iio.git.  Not sure on timings for the merge
window, but chances are high that this is just too late I'm afraid and will
have to wait for next time around.

Jonathan
>> ---
>>  .../devicetree/bindings/iio/accel/bma180.txt       |   24 +
>>  drivers/iio/accel/Kconfig                          |   12 +
>>  drivers/iio/accel/Makefile                         |    2 +
>>  drivers/iio/accel/bma180.c                         |  676 ++++++++++++++++++++
>>  4 files changed, 714 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/iio/accel/bma180.txt
>>  create mode 100644 drivers/iio/accel/bma180.c
>>
>> diff --git a/Documentation/devicetree/bindings/iio/accel/bma180.txt b/Documentation/devicetree/bindings/iio/accel/bma180.txt
>> new file mode 100644
>> index 0000000..c593357
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/accel/bma180.txt
>> @@ -0,0 +1,24 @@
>> +* Bosch BMA180 triaxial acceleration sensor
>> +
>> +http://omapworld.com/BMA180_111_1002839.pdf
>> +
>> +Required properties:
>> +
>> +  - compatible : should be "bosch,bma180"
>> +  - reg : the I2C address of the sensor
>> +
>> +Optional properties:
>> +
>> +  - interrupt-parent : should be the phandle for the interrupt controller
>> +
>> +  - interrupts : interrupt mapping for GPIO IRQ, it should by configured with
>> +               flags IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_EDGE_RISING
>> +
> 
> One thing I noticed from the datasheet is that this has a clock input
> (sck) and two regulator inputs (vdd and vddio). It might not always be
> the case that these are configured statically, so they may need to be
> described in the dt. It's possible that they could be added later as
> optional properties, though.
> 
> Thanks,
> Mark.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/