Re: [PATCH] dynamic debug: line queries failing due to uninitializedlocal variable

From: Jason Baron
Date: Wed Aug 28 2013 - 10:53:46 EST


On 08/27/2013 01:41 PM, Greg KH wrote:
> On Tue, Aug 27, 2013 at 04:50:03PM +0000, jbaron@xxxxxxxxxx wrote:
>> Settings of the form, 'line x module y +p', can fail arbitrarily due to an
>> uninitialized local variable. With this patch results are consistent, as
>> expected.
>>
>> Signed-off-by: Jason Baron <jbaron@xxxxxxxxxx>
>> ---
>> lib/dynamic_debug.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> How far back should this patch go for older kernels? Is this a bug that
> people are hitting today and causing problems, or is it only a 3.11-rc
> issue?
>
> thanks,
>
> greg k-h

Looks like this was introduced in >= 3.3. So its been there for quite a
while. Its a bit of a corner case, since it requires, 'line' to be
specified before anything else. It depends on on how you order your query.

I found the bug via code inspection - no bug reports that I'm aware of.
So I wouldn't think this is an urgent fix.

Thanks,

-Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/