Re: [PATCH] pinctrl: at91: add support for OUTPUT config

From: Linus Walleij
Date: Wed Aug 28 2013 - 09:48:46 EST


On Wed, Aug 28, 2013 at 3:46 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Tue, Aug 27, 2013 at 4:51 PM, Boris BREZILLON
> <b.brezillon@xxxxxxxxxxx> wrote:
>
>> Add support for pin output control through the pinctrl config:
>> - support enabling/disabling output on a given pin
>> - support output level setting (high or low)
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon@xxxxxxxxxxx>
>
> NAK.
>
> We already have this:
>
> * @PIN_CONFIG_OUTPUT: this will configure the pin in output, use argument
> * 1 to indicate high level, argument 0 to indicate low level.
>
> It also has device tree bindings:
>
> output-low - set the pin to output mode with low level
> output-high - set the pin to output mode with high level

Bah maybe I'm misunderstanding :-(

So this is not part of the generic pin config series, but something
stand-alone to augment the existing driver to do this?

So I just apply this patch right off then?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/