Re: [PATCH RFC v2 1/2] qspinlock: Introducing a 4-byte queuespinlock implementation

From: Peter Zijlstra
Date: Wed Aug 28 2013 - 09:37:19 EST


On Wed, Aug 28, 2013 at 09:15:30AM -0400, Steven Rostedt wrote:
> Are you for the smp_mb__after_spin_unlock() ?

Sure, if the performance gains of having it out-weight the added
complexity of having it :-)

Nice non answer methinks, no? Muwhaha. To me having one more or less
'conditional' full mb primitive really doesn't matter anymore.

I'm presuming you're doing this for performance gains on anything other
than x86 though, as x86 has a non-atomic unlock and thus always requires
the full barrier thing here (yes yes I know ia32 still exists but people
should really really really kill that thing already).

> I'm getting confused by who is arguing what :-)

Hehe ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/