Re: [PATCH] ARM: integrator: Make sure INTEGRATOR_AP depends on PCI

[Linus Walleij]

On Wed, Aug 14, 2013 at 10:04 PM, Joerg Roedel <joro@xxxxxxxxxx> wrote:

> So when integrator does not depend on PCI this diff is more appropriate?
>
> diff --git a/arch/arm/mach-integrator/pci_v3.h b/arch/arm/mach-integrator/pci_v3.h
> index 755fd29..51738e0 100644
> --- a/arch/arm/mach-integrator/pci_v3.h
> +++ b/arch/arm/mach-integrator/pci_v3.h
> @@ -1,2 +1,9 @@
> -/* Simple oneliner include to the PCIv3 early init */
> +/* Define PCIv3 early init */
> +#ifdef CONFIG_PCI
>  extern int pci_v3_early_init(void);
> +#else
> +static inline int pci_v3_early_init(void)
> +{
> +       return 0;
> +}
> +#endif

Yes.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

And can you please create and send a proper patch with this
content to arm@xxxxxxxxxx and the mailing list on CC, with
a request for the ARM SoC maintainers to apply it directly
as a fix?

You might as well add Cc: stable@xxxxxxxxxxxxxxx as well.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/