Re: [PATCH 4/6] Move might_sleep and friends from kernel.h tosched.h

From: Andrew Morton
Date: Tue Aug 27 2013 - 19:50:19 EST


On Fri, 16 Aug 2013 14:17:22 -0700 Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> These are really related to scheduling, so they should be in sched.h
> Users usually will need to schedule anyways.
>
> The advantage of having them there is that we can access some of the
> scheduler inlines to make their fast path more efficient. This will come
> in a followon patch.

alpha allmodconfig:

mm/memory.c:4236: error: redefinition of 'might_fault'
include/linux/sched.h:2485: note: previous definition of 'might_fault' was here

Presumably because CONFIG_PROVE_LOCKING=n && CONFIG_DEBUG_ATOMIC_SLEEP=y.

That code is too tangly for me to fix it up with any confidence, sorry.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/