Re: [PATCH] serial: omap: Fix IRQ handling return value

From: Greg KH
Date: Tue Aug 27 2013 - 19:01:53 EST


On Tue, Aug 20, 2013 at 08:44:50AM -0700, Kevin Hilman wrote:
> +Felipe
>
> On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko
> <oleksandr.savchenko@xxxxxx> wrote:
> > From: Ruchika Kharwar <ruchika@xxxxxx>
> >
> > Ensure the Interrupt handling routine return IRQ_HANDLED vs
> > IRQ_NONE.
>
> Why?
>
> By unconditionally returning IRQ_HANDLED, this patch will surely break
> systems where the UART IRQ is shared with other platforms.
>
> I just noticed this patch when bisecting a related problem. Why
> wasn't this Cc'd to linux-omap where OMAP users might have been more
> likely to see it?
>
> Greg, without a better justification in the changelog, I think this
> patch should be dropped from tty-next.

Now reverted, sorry for the delay.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/