Re: [PATCH v7 02/10] tracing: add basic event trigger framework

[Steven Rostedt]

On Tue, 27 Aug 2013 14:40:14 -0500
Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx> wrote:

> +
> +	if (copy_from_user(buf, ubuf, cnt)) {
> +		free_page((unsigned long) buf);
> +		return -EFAULT;
> +	}
> +	buf[cnt] = '\0';
> +	strim(buf);
> +
> +	mutex_lock(&event_mutex);
> +	event_file = event_file_data(file);
> +	if (unlikely(!event_file)) {
> +		mutex_unlock(&event_mutex);
> +		free_page((unsigned long) buf);

Nitpick... Nuke the space before "buf".

-- Steve

> +		return -ENODEV;
> +	}
> +	ret = trigger_process_regex(event_file, buf, enable);
> +	mutex_unlock(&event_mutex);
> +
> +	free_page((unsigned long) buf);
> +	if (ret < 0)
> +		goto out;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/